Repository navigation
fix(resizer): keep height_quickfix when focus leaves the quickfix window - #183
Merged
Merged
Conversation
The quickfix height was only applied while the quickfix window was focused. Resizing the newly focused window then changed the quickfix height. Treat quickfix windows as fixed-height during autoresize. Fixes #179
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #179.
height_quickfixwas applied only while the quickfix window was focused. When focus moved to another window, resizing that window changed the quickfix height.Quickfix windows (
filetype == 'qf') are now saved and restored as fixed-height windows during autoresize and equalise, usingheight_quickfixwhen it is greater than 0.maximiseis unchanged.Test:
quickfix keeps height_quickfix when focus leavesintests/test_autoresize.luafails on master (qf height 7, expected 5) and passes with this change. The only failing test in the suite issetup() validates config argument, which also fails on master with Neovim 0.12.6.